Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spacing of error message is too long with <br> #28452

Closed
jennifer-shehane opened this issue Dec 4, 2023 · 2 comments · Fixed by #28496
Closed

Spacing of error message is too long with <br> #28452

jennifer-shehane opened this issue Dec 4, 2023 · 2 comments · Fixed by #28496
Labels
good first issue Good for newcomers type: error message type: user experience Improvements needed for UX v12.4.0 🐛

Comments

@jennifer-shehane
Copy link
Member

jennifer-shehane commented Dec 4, 2023 •
edited

Current behavior

image (4)
image (5)

The error messages appear to have really wide spacing. They didn't used to have this. Maybe it changed in 10.0.

Desired behavior

Spacing should not be so far apart in error messages. We should look at older versions of Cypress and how it used to look to compare when it changed and reduce spacing. Will have to update a lot of snapshots.

Test code to reproduce

cy.click on non-visible element

Cypress Version

13.6.0

Node version

18

Operating System

Mac

Debug Logs

No response

Other

No response
@jennifer-shehane
Copy link
Member Author

jennifer-shehane commented Dec 11, 2023 •
edited

This was introduced in 12.4.0.

Screenshot from 12.3.0:

Screen Shot 2023-12-11 at 11 22 18 AM

Screen Shot 2023-12-11 at 12 12 39 PM

@jennifer-shehane jennifer-shehane mentioned this issue Dec 11, 2023
Merged
1 task
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 26, 2023

Released in 13.6.2.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.6.2, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Dec 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers type: error message type: user experience Improvements needed for UX v12.4.0 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Remove erroneous <br> tags from error messages cypress-io/cypress
1 participant
@jennifer-shehane