Possibly wrong match on topOrParentLocationOrFramesRe regexp

[leandro-serafim]

Current behavior:

Currently, having modifyObstructiveCode enabled didn't get a specific framebust situation:

top.location!=self.location&&(top.location.href=self.location.href)

After researching over the code base I could identify the regexp used on topOrParentLocationOrFramesRe possibly isn't getting correctly the first group match, as you can see: (https://regex101.com/r/o0ykmR/1)

Desired behavior:

I'd like to be able to block the given framebust.

Steps to reproduce: (app code and test code)

The regexp on topOrParentLocationOrFramesRe gets an extra character as you see here

Possibly the easiest fix I'd suggest could be:
https://regex101.com/r/Ophqrr/2

Versions

Cypress: v3.1.5
Windows 11
Chrome: 71.x

[jennifer-shehane]

Thanks for the thorough investigation of the issue. Gotta <3 Regex. We'll have to update the regex, write a test to ensure it fixes this issue and ensure no other framebusting tests fail.

[jennifer-shehane]

I opened a PR here: #3279

[cypress-bot]

Released in 3.2.0.