Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should handle rejected promise without error object better #3283

Open
bahmutov opened this issue Feb 1, 2019 · 7 comments
Open

We should handle rejected promise without error object better #3283

bahmutov opened this issue Feb 1, 2019 · 7 comments
Labels
E2E Issue related to end-to-end testing pkg/driver This is due to an issue in the packages/driver directory topic: unhandled exceptions ⚠️ Issues involving unhandled or uncaught exception handling Triaged Issue has been routed to backlog. This is not a commitment to have it prioritized by the team. type: user experience Improvements needed for UX

Comments

@bahmutov
Copy link
Contributor

bahmutov commented Feb 1, 2019

Cypress 3.1.5

PR with bug reproduction cypress-io/cypress-test-tiny#35

spec

/// <reference types="cypress" />
describe('page', () => {
  it('fails', () => {
    cy.wrap(null).then(Cypress.Promise.reject)
  })
})

When running shows our error

screen shot 2019-02-01 at 11 11 54 am

The stack shows where the error is coming from - we are checking err. property, but there is no err

screen shot 2019-02-01 at 11 12 13 am

@jennifer-shehane jennifer-shehane added stage: ready for work The issue is reproducible and in scope type: user experience Improvements needed for UX pkg/driver This is due to an issue in the packages/driver directory labels Feb 5, 2019
@jennifer-shehane jennifer-shehane added the topic: unhandled exceptions ⚠️ Issues involving unhandled or uncaught exception handling label Jul 12, 2019
@jennifer-shehane
Copy link
Member

This is still happening in Cypress version 3.4.0

@jennifer-shehane
Copy link
Member

This fails with a new error msg in 4.5.0+, no stack trace.

Screen Shot 2020-05-18 at 12 04 11 PM

@alexey-sh
Copy link

It's sad to see that cypress doesn't support so basic features... Maybe it will be added in future. How many years should it take?

@cypress-app-bot
Copy link
Collaborator

This issue has not had any activity in 180 days. Cypress evolves quickly and the reported behavior should be tested on the latest version of Cypress to verify the behavior is still occurring. It will be closed in 14 days if no updates are provided.

@cypress-app-bot cypress-app-bot added the stale no activity on this issue for a long period label May 18, 2023
@alexey-sh
Copy link

I bet the issue is going to be closed due to poor support

@nagash77 nagash77 added E2E Issue related to end-to-end testing Triaged Issue has been routed to backlog. This is not a commitment to have it prioritized by the team. and removed stage: ready for work The issue is reproducible and in scope stale no activity on this issue for a long period labels May 19, 2023
@nagash77
Copy link
Contributor

@alexey-sh we are trying to improve our support channels as we scale as a company. This issue was incorrectly picked up by the stale bot. Do not worry, it is not going to be closed at this point. Thank you for your kind words and continued support.

@bahmutov
Copy link
Contributor Author

The automatic stale bot should skip any issue reported by me, just saying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E2E Issue related to end-to-end testing pkg/driver This is due to an issue in the packages/driver directory topic: unhandled exceptions ⚠️ Issues involving unhandled or uncaught exception handling Triaged Issue has been routed to backlog. This is not a commitment to have it prioritized by the team. type: user experience Improvements needed for UX
Projects
None yet
Development

No branches or pull requests

5 participants