Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[develop] dom highlights need to account for box-sizing: border-box #5239

Closed
kuceb opened this issue Sep 29, 2019 · 2 comments · Fixed by #5246
Closed

[develop] dom highlights need to account for box-sizing: border-box #5239

kuceb opened this issue Sep 29, 2019 · 2 comments · Fixed by #5246

Comments

@kuceb
Copy link
Contributor

kuceb commented Sep 29, 2019 •
edited
Loading

edit: Only occuring in develop due to Jquery upgrade

when element has box-sizing: border-box, we need to subtract padding from total height to calculate "content" highlight

With border-box, without border-box

out2

most css frameworks set * {box-sizing: border-box}
@kuceb kuceb changed the title dom highlights need to account for box-sizing: border-box [devlop] dom highlights need to account for box-sizing: border-box Sep 29, 2019
@kuceb kuceb mentioned this issue Sep 30, 2019
Merged
3 tasks
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Sep 30, 2019
@kuceb kuceb changed the title [devlop] dom highlights need to account for box-sizing: border-box [develop] dom highlights need to account for box-sizing: border-box Sep 30, 2019
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: needs review The PR code is done & tested, needs review stage: work in progress labels Sep 30, 2019
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Oct 2, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 2, 2019

The code for this is done in cypress-io/cypress#5246, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 23, 2019

Released in 3.5.0.

@cypress-io cypress-io locked as resolved and limited conversation to collaborators Dec 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: switch back to using jquery width/height on element dimensions cypress-io/cypress
1 participant
@kuceb