Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waitingForActionability should run through all check synchronously #570

Closed
brian-mann opened this issue Jul 21, 2017 · 2 comments
Closed
Assignees
Labels
type: unexpected behavior User expected result, but got another
Milestone

Comments

@brian-mann
Copy link
Member

  • Cypress Version: 0.19.4

Current behavior:

Cypress will asynchronously run checks to determine an elements actionability.

This is problematic because there is a chance that an element "moves" or otherwise changes in between the checks, and this can lead to incorrect behavior.

Desired behavior:

Run through all checks synchronously, if any fail, retry them all, if they all pass, proceed with the action synchronously.

@brian-mann brian-mann added the type: unexpected behavior User expected result, but got another label Jul 21, 2017
@brian-mann brian-mann self-assigned this Jul 21, 2017
@brian-mann
Copy link
Member Author

The code for this is done, but this has yet to be released. We'll update the issue and reference the changelog when it's released.

@brian-mann
Copy link
Member Author

Fixed in 0.20.0

@cypress-io cypress-io locked as resolved and limited conversation to collaborators Apr 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: unexpected behavior User expected result, but got another
Projects
None yet
Development

No branches or pull requests

2 participants