Since 3.5.0, a cy.visit that changes superdomain incorrectly clears cookies of other domains.

[flotwig]

Current behavior:

Given the following flow:

1. http://foo.com sets cookie foo=bar and redirects to http://bar.com
2. http://bar.com returns 200

cy.visit("http://foo.com") with a current superdomain of foo.com will result in no cookies being set, since the superdomain changes and causes the cookies to erroneously be cleared.

Desired behavior:

Cookies are kept from all redirects during a cy.visit.

This can be accomplished by getting rid of the shortcut we take to make cy.visit only send 1 HTTP request, even if superdomain changes. This shortcut is the root of all evil:

cypress/packages/server/lib/server.coffee

Lines 364 to 382 in 0a24df2

	## if we have a buffer for this url
	## then just respond with its details
	## so we are idempotant and do not make
	## another request
	if obj = buffers.getByOriginalUrl(urlStr)
	debug("got previous request buffer for url:", urlStr)
	## reset the cookies from the buffer on the browser
	return runPhase ->
	resolve(
	Promise.map obj.details.cookies, (cookie) ->
	## prevent prepending a . to the cookie domain if top-level
	## navigation occurs as a result of a cy.visit
	if _.isUndefined(cookie.hostOnly) && !cookie.domain?.startsWith('.')
	cookie.hostOnly = true
	automationRequest('set:cookie', cookie)
	.return(obj.details)
	)

Steps to reproduce: (app code and test code)

See #5702 for reproduction.

Versions

Cypress >=3.5.0

[cypress-bot]

The code for this is done in cypress-io/cypress#5702, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

[cypress-bot]

Released in 3.7.0.