Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI needs TypeScript type checker. #5772

Closed
sainthkh opened this issue Nov 22, 2019 · 3 comments · Fixed by #5780
Closed

CI needs TypeScript type checker. #5772

sainthkh opened this issue Nov 22, 2019 · 3 comments · Fixed by #5780
Assignees
@sainthkh
Labels
type: chore Work is required w/ no deliverable to end user

Comments

@sainthkh
Copy link
Contributor

Current behavior:

In #5666, CI didn't fail even when there was wrong types in TypeScript code. We need type checker in CI

Desired behavior:

When type went wrong, CI should fail.

Steps to reproduce: (app code and test code)

Create typescript code with wrong types. It still passes.

Versions

develop branch
@sainthkh
Copy link
Contributor Author

I'm thinking about copying and adapting this from kibana.

@sainthkh sainthkh mentioned this issue Nov 23, 2019
Merged
1 task
@jennifer-shehane jennifer-shehane added process: code type: chore Work is required w/ no deliverable to end user labels Jan 2, 2020
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Jan 16, 2020
@cypress-bot cypress-bot bot added stage: work in progress and removed stage: needs review The PR code is done & tested, needs review labels Feb 3, 2020
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Feb 18, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 17, 2020

The code for this is done in cypress-io/cypress#5780, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot removed the stage: needs review The PR code is done & tested, needs review label Mar 17, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 30, 2020

Released in 4.3.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.3.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sainthkh sainthkh

Labels
type: chore Work is required w/ no deliverable to end user
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added TypeScript type checker + Fixed type errors. sainthkh/cypress
2 participants
@jennifer-shehane @sainthkh