Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter non-default orgs before checking to display empty orgs view during project setup #5954

Closed
jennifer-shehane opened this issue Dec 13, 2019 · 2 comments · Fixed by #5955 · May be fixed by qsays/grafana#1
Closed

Filter non-default orgs before checking to display empty orgs view during project setup #5954

jennifer-shehane opened this issue Dec 13, 2019 · 2 comments · Fixed by #5955 · May be fixed by qsays/grafana#1
Assignees
Labels

Comments

@jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Dec 13, 2019

Current behavior:

Our services are moving away from always utilizing a 'default organization'. The Desktop-Gui however is naively expecting a 'default organization' to always be present.

The user facing consequence of this is that if an organization has 1 organization that is not a default organization - maybe they converted it to professional (this actually can't happen because we create a new default org) or only have 1 organization setup due to SSO login - then the organization selection will display as empty and they cannot select an organization to set up their project within.

no-orgs copy

Desired behavior:

The Desktop-GUI should first filter out any default orgs and then check the length of the leftover orgs to decide whether the empty view displays for orgs. Not naively check that is is > 1 in length total.

Versions

3.7.0

To Fix:

This line needs to filter our orgs that have default: true first, and then check if the length of the remaining orgs is greater than 1.

https://github.com/cypress-io/cypress/blob/develop/packages/desktop-gui/src/runs/setup-project-modal.jsx#L221:L221

@jennifer-shehane jennifer-shehane self-assigned this Dec 13, 2019
@jennifer-shehane jennifer-shehane changed the title Filter non-default orgs before checking to display empty v Filter non-default orgs before checking to display empty orgs view during project setup Dec 13, 2019
@jennifer-shehane jennifer-shehane added the external: api label Dec 13, 2019
@cypress-bot cypress-bot bot added stage: needs review stage: work in progress and removed stage: ready for work stage: needs review stage: work in progress labels Dec 13, 2019
@cypress-bot cypress-bot bot added the stage: pending release label Dec 19, 2019
@cypress-bot
Copy link

@cypress-bot cypress-bot bot commented Dec 19, 2019

The code for this is done in cypress-io/cypress#5955, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot removed the stage: needs review label Dec 19, 2019
@cypress-bot
Copy link

@cypress-bot cypress-bot bot commented Dec 26, 2019

Released in 3.8.1.

@cypress-bot cypress-bot bot removed the stage: pending release label Dec 26, 2019
@cypress-io cypress-io locked as resolved and limited conversation to collaborators Dec 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
1 participant