Filter non-default orgs before checking to display empty orgs view during project setup

[jennifer-shehane]

Current behavior:

Our services are moving away from always utilizing a 'default organization'. The Desktop-Gui however is naively expecting a 'default organization' to always be present.

The user facing consequence of this is that if an organization has 1 organization that is not a default organization - maybe they converted it to professional (this actually can't happen because we create a new default org) or only have 1 organization setup due to SSO login - then the organization selection will display as empty and they cannot select an organization to set up their project within.

Desired behavior:

The Desktop-GUI should first filter out any default orgs and then check the length of the leftover orgs to decide whether the empty view displays for orgs. Not naively check that is is > 1 in length total.

Versions

3.7.0

To Fix:

This line needs to filter our orgs that have default: true first, and then check if the length of the remaining orgs is greater than 1.

https://github.com/cypress-io/cypress/blob/develop/packages/desktop-gui/src/runs/setup-project-modal.jsx#L221:L221

[cypress-bot]

The code for this is done in cypress-io/cypress#5955, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

[cypress-bot]

Released in 3.8.1.