Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spec header with link to open file in editor #7506

Closed
panzarino opened this issue May 27, 2020 · 2 comments · Fixed by #7515
Closed

Add spec header with link to open file in editor #7506

panzarino opened this issue May 27, 2020 · 2 comments · Fixed by #7515
Assignees
@panzarino
Labels
pkg/runner This is due to an issue in the packages/runner directory type: feature New feature that does not currently exist

Comments

@panzarino
Copy link
Contributor

panzarino commented May 27, 2020 •
edited

When running tests in the Test Runner, I want each spec header to be sticky and clickable and opens the spec in my code editor, so that I can easily get to my spec and make changes.

  • Spec header is sticky
  • Spec header will have a background color of #f2f2f2 and will have a drop shadow
  • Spec headers will show the file path
  • File path will be semi-bold font weight
  • File path is centered vertically in the div
  • File path has a hover state where the path is underlined
  • Clicking the file path opens the user’s IDE at that file
  • Matches design

Design:
Screen Shot 2020-05-27 at 4 14 46 PM
@panzarino panzarino added the pkg/runner This is due to an issue in the packages/runner directory label May 27, 2020
@panzarino panzarino self-assigned this May 27, 2020
@jennifer-shehane jennifer-shehane added the type: feature New feature that does not currently exist label May 28, 2020
@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label May 28, 2020
@panzarino panzarino mentioned this issue May 28, 2020
Merged
3 tasks
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope stage: work in progress stage: needs review The PR code is done & tested, needs review labels May 28, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 5, 2020

The code for this is done in cypress-io/cypress#7515, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot removed the stage: needs review The PR code is done & tested, needs review label Jun 5, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 8, 2020

Released in 4.8.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.8.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jun 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@panzarino panzarino

Labels
pkg/runner This is due to an issue in the packages/runner directory type: feature New feature that does not currently exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add spec header with link to open file in editor cypress-io/cypress
2 participants
@jennifer-shehane @panzarino