Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server/lib/errors.js is unreadable after decaffeination #7629

Closed
jennifer-shehane opened this issue Jun 9, 2020 · 2 comments · Fixed by #7633
Closed

server/lib/errors.js is unreadable after decaffeination #7629

jennifer-shehane opened this issue Jun 9, 2020 · 2 comments · Fixed by #7633
Labels
process: contributing Related to contributing to the Cypress codebase type: chore Work is required w/ no deliverable to end user

Comments

@jennifer-shehane
Copy link
Member

Current behavior:

I can't easily distinguish errors from one another in this file after it was converted from coffeescript.

https://github.com/cypress-io/cypress/blob/develop/packages/server/lib/errors.js#L516:L516

Desired behavior:

Typically we use stripIndent to maintain indentation so it's readable.

Versions

4.8.0
@jennifer-shehane jennifer-shehane added type: chore Work is required w/ no deliverable to end user process: contributing Related to contributing to the Cypress codebase labels Jun 9, 2020
@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Jun 9, 2020
@jennifer-shehane jennifer-shehane mentioned this issue Jun 9, 2020
Merged
3 tasks
@sainthkh sainthkh mentioned this issue Jun 9, 2020
Merged
1 task
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope stage: work in progress labels Jun 9, 2020
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Jun 12, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 12, 2020

The code for this is done in cypress-io/cypress#7633, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@jennifer-shehane
Copy link
Member Author

Released.

This comment thread has been locked as resolved.

@cypress-io cypress-io locked as resolved and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
process: contributing Related to contributing to the Cypress codebase type: chore Work is required w/ no deliverable to end user
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: fix server/lib/errors.js readability. sainthkh/cypress
1 participant
@jennifer-shehane