Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command Timeout Indicator [TTR-36] #7642

Closed
panzarino opened this issue Jun 9, 2020 · 2 comments · Fixed by #7646
Closed

Command Timeout Indicator [TTR-36] #7642

panzarino opened this issue Jun 9, 2020 · 2 comments · Fixed by #7646
Assignees
@panzarino
Labels
pkg/reporter This is due to an issue in the packages/reporter directory type: enhancement Requested enhancement of existing feature type: user experience Improvements needed for UX

Comments

@panzarino
Copy link
Contributor

panzarino commented Jun 9, 2020 •
edited

Adds a command timeout progress bar underneath each running command.

  • As a command is pending, a progress indicator appears at the bottom of the command line item
  • The progress indicator has a background color of #7EB0DB
  • The progress indicator should be 2px tall
  • The horizontal length of the progress indicator will shortened from left to right as the command pends
    • The progress indicator should progress smoothly

Screen Shot 2020-06-09 at 3 34 34 PM
@panzarino panzarino added type: enhancement Requested enhancement of existing feature pkg/reporter This is due to an issue in the packages/reporter directory type: user experience Improvements needed for UX labels Jun 9, 2020
@panzarino panzarino self-assigned this Jun 9, 2020
@panzarino panzarino mentioned this issue Jun 9, 2020
Merged
5 tasks
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: work in progress stage: needs review The PR code is done & tested, needs review labels Jun 9, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 16, 2020

The code for this is done in cypress-io/cypress#7646, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot removed the stage: needs review The PR code is done & tested, needs review label Jun 16, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 23, 2020

Released in 4.9.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.9.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jun 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@panzarino panzarino

Labels
pkg/reporter This is due to an issue in the packages/reporter directory type: enhancement Requested enhancement of existing feature type: user experience Improvements needed for UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Command Timeout Progress Bar cypress-io/cypress
1 participant
@panzarino