Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): cy.wait yields previous subject #7682

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Jun 11, 2020

User facing changelog

  • Updated type defitions for cy.wait(ms) to correctly yield the type of the previous Subject.

Additional details

Updated types to match the docs:

image

PR Tasks

  • Have tests been added/updated?
  • Has the original issue been tagged with a release in ZenHub?
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

@flotwig flotwig added the type: typings Issue related to Cypress types (for TypeScript) label Jun 11, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 11, 2020

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Jun 11, 2020



Test summary

7586 0 119 0


Run details

Project cypress
Status Passed
Commit ce2e0aa
Started Jun 11, 2020 8:41 PM
Ended Jun 11, 2020 8:47 PM
Duration 06:50 💡
OS Linux Debian - 10.1
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig flotwig marked this pull request as ready for review June 11, 2020 21:02
@flotwig flotwig requested review from a team, JessicaSachs and kuceb and removed request for a team June 11, 2020 21:02
Copy link
Contributor

@JessicaSachs JessicaSachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! My first exposure to our ts testing setup. It’s really interesting.

@jennifer-shehane jennifer-shehane merged commit d3acf91 into develop Jun 12, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 23, 2020

Released in 4.9.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.9.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jun 23, 2020
@flotwig flotwig deleted the fix-wait-ms-return-type branch January 24, 2022 18:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: typings Issue related to Cypress types (for TypeScript)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants