Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add typing for specType field on spec method #8256

Merged

Conversation

NickBolles
Copy link
Contributor

@NickBolles NickBolles commented Aug 12, 2020

  • Closes

User facing changelog

Add typings for specType field on Cypress.spec

Additional details

Typescript users will get a compilation error

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
    n/a
  • Has the original issue been tagged with a release in ZenHub?
    n/a
  • Has a PR for user-facing changes been opened in cypress-documentation?
    n/a
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?
    n/a

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 12, 2020

Thanks for taking the time to open a PR!

@CLAassistant
Copy link

CLAassistant commented Aug 12, 2020

CLA assistant check
All committers have signed the CLA.

@NickBolles NickBolles changed the title Add typing for specType field on spec method fix: Add typing for specType field on spec method Aug 12, 2020
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NickBolles There are quite a few errors in our Type linter, could you take a look? https://circleci.com/gh/cypress-io/cypress/419610

@NickBolles
Copy link
Contributor Author

@jennifer-shehane I just tried something, but I'm on my phone. If that doesn't work I'll check it out tomorrow on my computer.

Copy link
Contributor

@bahmutov bahmutov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please fix the lint errors and add a JSDoc for the new type explaining those two types? With @see links to our docs

@jennifer-shehane
Copy link
Member

@NickBolles Do you still have time to address the changes requested in this PR? We will have to close this PR due to inactivity otherwise.

@NickBolles
Copy link
Contributor Author

@jennifer-shehane That should take care of the linting issues. Thanks for the ping, let me know if there's anything else I need to do.

@jennifer-shehane jennifer-shehane dismissed their stale review August 26, 2020 08:59

dismissing my previous review

@jennifer-shehane jennifer-shehane dismissed bahmutov’s stale review August 27, 2020 05:17

Dismissing previous review as addressed

@jennifer-shehane jennifer-shehane merged commit 12080dc into cypress-io:develop Aug 27, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 1, 2020

Released in 5.1.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v5.1.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Sep 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants