feat(driver): add some iphone viewport

[ryota-murakami]

User facing changelog

• Added viewport preset of iphone-7, iphone-8, iphone-se2

Additional details

sake: improve Developer Experience

viewport preset consider useful most people because people tend to memorize mobile device naming e.g. google-pixel, samsung galaxy etc clearly more than device pixels number.

So, This time I added 3 devices that has exact same resolution as a iphone-6(750 x 1334)
source: https://devhints.io/resolutions source hosted github repo over 9,000 and maintain frequency. Seems trusted.

this is draft pull request

In the first place I don't know Cypress dev team has positive feeling about support more viewport,

so I started super low regression risk part.

If Cypress dev team had agree with positive, I'll add some popular devices viewport e.g. google-pixel series, galaxy s20, ipad-pro, ipad-air, series, ipad-3, ipad-4, ipad-5, ipad-6, ipad-7, ipad-8(modern days, call that ipad-8gen generation style also popular on net news, SNS etc.

How has the user experience changed?

Cypress user can use familiar mobile device screen size easily, less research time about cypress viewport preset detail.

Unlike me, I have iphone-7 in real life so I attempt use it viewport, but I can't figure out next number of iphone-7... 🤔❓😭

PR Tasks

• Have tests been added/updated?
  - [ ] Has the original issue been tagged with a release in ZenHub?
• Has a PR for user-facing changes been opened in https://docs.cypress.io/api/commands/viewport.html#Arguments ?
• Have API changes been updated in the type definitions?
  - [ ] Have new configuration options been added to the cypress.schema.json?

Every feedback welcome, I'm glad got comments some thought when you have plenty time and your smartphone doesn't exist in viewport. 😅

Thank you for reading about this! 🤗

[cypress-bot]

Thanks for taking the time to open a PR!

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
• Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

[CLAassistant]

All committers have signed the CLA.

[jennifer-shehane]

@ryota-murakami I see this is still in Draft, is this ready for review or will you have time to finish this PR?

[ryota-murakami]

@jennifer-shehane Thank you mentioning it, It's ready for review so I just update PR status from Draft!

[jennifer-shehane]

Can you update the types to reflect the new presets? https://github.com/cypress-io/cypress/blob/develop/cli/types/cypress.d.ts#L5298:L5298

Also, could you open a pull request against our docs to document the new viewport presets?

[ryota-murakami]

@jennifer-shehane

Also, could you open a pull request against our docs to document the new viewport presets?

Sure, I'll update docs viewport presets section and raise PR! 😀

[jennifer-shehane]

@ryota-murakami I think for future new viewport sizes, we're thinking to pull in some outside dependency where we can request viewports / sizes and use those as the available viewports. Because keeping up with an arbitrary list that people add to just might get out of hand. Just so that answers your question about newer viewports. Maybe there's a library that lists those we can pull in.

That or maybe there's a way to reference or pull in Google Chrome device sizes that they use in emulation mode. Ideally our viewports would match those.

[ryota-murakami]

Also, could you open a pull request against our docs to document the new viewport presets?

@jennifer-shehane I send PR to Docs repo that added exact same iphone medels.
cypress-io/cypress-documentation#3229

[ryota-murakami]

@jennifer-shehane Thank you for your answer about viewport direction.

Maybe there's a library that lists those we can pull in.

That's might be cool, I'm looking forward to that! 🤗

[cypress-bot]

Released in 5.4.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v5.4.0, please open a new issue.