Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack-preprocessor): fix webpack preprocessor potential race condition #8976

Merged
merged 2 commits into from
Oct 27, 2020

Conversation

kuceb
Copy link
Contributor

@kuceb kuceb commented Oct 26, 2020

fixes potential race condition causing tests to flake

Changelog

Bug Fix: [webpack-preprocessor] fix race condition causing file changes to occasionally not register

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 26, 2020

Thanks for taking the time to open a PR!

@kuceb kuceb changed the base branch from develop to master October 26, 2020 21:21
Copy link
Contributor

@flotwig flotwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, doesn't this mean that preprocessor()(file) is resolving 1 tick too early? isn't the fix in the code itself?

@cypress
Copy link

cypress bot commented Oct 26, 2020



Test summary

8614 0 124 3Flakiness 2


Run details

Project cypress
Status Passed
Commit a3f1591
Started Oct 27, 2020 2:30 PM
Ended Oct 27, 2020 2:42 PM
Duration 12:11 💡
OS Linux Debian - 10.2
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

commands/net_stubbing_spec.ts Flakiness
1 network stubbing > stubbing with static responses > still works after a cy.visit
retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@kuceb kuceb dismissed a stale review via a3f1591 October 27, 2020 14:19
@kuceb
Copy link
Contributor Author

kuceb commented Oct 27, 2020

@flotwig very observant

@kuceb kuceb requested a review from flotwig October 27, 2020 14:20
Copy link
Contributor

@chrisbreiding chrisbreiding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Should this be changed to a fix so it releases a new version, since it's fixing the potential race condition in the preprocessor itself?

@kuceb kuceb changed the title chore(flake): fix webpack preprocessor flaky tests fix(webpack-preprocessor): fix webpack preprocessor flaky tests Oct 27, 2020
@kuceb kuceb changed the title fix(webpack-preprocessor): fix webpack preprocessor flaky tests fix(webpack-preprocessor): fix webpack preprocessor potential race condition Oct 27, 2020
@kuceb kuceb merged commit 5e0e5d8 into master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants