-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webpack-preprocessor): fix webpack preprocessor potential race condition #8976
Conversation
Thanks for taking the time to open a PR!
|
a9660d3
to
23488f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, doesn't this mean that preprocessor()(file)
is resolving 1 tick too early? isn't the fix in the code itself?
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
@flotwig very observant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Should this be changed to a fix
so it releases a new version, since it's fixing the potential race condition in the preprocessor itself?
fixes potential race condition causing tests to flake
Changelog
Bug Fix: [webpack-preprocessor] fix race condition causing file changes to occasionally not register