Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webpack-preprocessor): Allow specifying typescript path #9312

Merged
merged 2 commits into from
Nov 30, 2020

Conversation

chrisbreiding
Copy link
Contributor

User facing changelog

  • Webpack preprocessor now allows passing the path to TypeScript via the typescript option.

Additional details

When we run the default preprocessor and require typescript, it ends up requiring cypress's own version of typescript and not the user's. This prevents us from monkey-patching the correct version of typescript for source maps compatibility.

We already search out the path to the user's typescript and pass it to the preprocessor. This utilizes that path to require typescript.

PR Tasks

  • Have tests been added/updated?
  • N/A Has the original issue or this PR been tagged with a release in ZenHub?
  • N/A Has a PR for user-facing changes been opened in cypress-documentation?
  • N/A Have API changes been updated in the type definitions?
  • N/A Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 24, 2020

Thanks for taking the time to open a PR!

@chrisbreiding chrisbreiding changed the base branch from develop to master November 24, 2020 16:24
@cypress
Copy link

cypress bot commented Nov 24, 2020



Test summary

8746 0 118 3Flakiness 1


Run details

Project cypress
Status Passed
Commit d26ee43
Started Nov 24, 2020 8:13 PM
Ended Nov 24, 2020 8:24 PM
Duration 11:03 💡
OS Linux Debian - 10.5
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that this fixes the original issue.

I thought this might have fixed some other weird ts issues:

Copy link
Contributor

@flotwig flotwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment on lines -204 to -205
// disable any overrides if
// we've explictly turned off sourcemaps
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dang it, how else am i supposed to read comments in my 40x12 terminal 😠

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TS error: Option 'sourceMap' cannot be specified with option 'inlineSourceMap'
3 participants