Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rule): add no-async-tests rule #61

Merged
merged 9 commits into from May 27, 2020
Merged

feat(rule): add no-async-tests rule #61

merged 9 commits into from May 27, 2020

Conversation

E-Kuerschner
Copy link
Contributor

Resolves #58

@E-Kuerschner
Copy link
Contributor Author

@chrisbreiding thanks for elaborating in the README

bahmutov
bahmutov reviewed May 27, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@chrisbreiding chrisbreiding changed the title no-async-tests feat(rule): add no-async-tests rule May 27, 2020
@chrisbreiding chrisbreiding merged commit 324ffac into cypress-io:master May 27, 2020
@chrisbreiding
Copy link
Contributor

🎉 This PR is included in version 2.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bahmutov bahmutov bahmutov left review comments

@chrisbreiding chrisbreiding Awaiting requested review from chrisbreiding

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

probably should warn about async tests
3 participants
@E-Kuerschner @chrisbreiding @bahmutov