Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addViewWithExpiryDate() does not exists (anymore) #87

Closed
francoism90 opened this issue Jul 22, 2018 · 6 comments
Closed

addViewWithExpiryDate() does not exists (anymore) #87

francoism90 opened this issue Jul 22, 2018 · 6 comments
Assignees
Labels
Status: Solved Used for solved questions Type: Question

Comments

@francoism90
Copy link

  • Eloquent Viewable: 2.1
  • Laravel Version: 5.6
  • PHP Version: 7.2
  • Database Driver & Version: MySQL 8

Description:

Has been removed? Only addView() seems to be available.

Steps To Reproduce:

Add steps of README

Expected behavior:

Is addView() doing the same and is addViewWithExpiryDate() not needed anymore?

Actual behavior:

Doesn't exists.

@cyrildewit
Copy link
Owner

I had bring this feature back to v2.1.0, but I apparently made a mistake, so the release does not contain anything. I'm working on it.

@cyrildewit
Copy link
Owner

I released a new minor version that contains the desired feature. Thank you for reporting.

See https://github.com/cyrildewit/eloquent-viewable/releases/tag/v2.2.0

@francoism90
Copy link
Author

@cyrildewit Many thanks for the update. :)

@cromartie1984
Copy link

It still do not exist on packagist....

@cyrildewit
Copy link
Owner

@cromartie1984 which version of this package do you have installed?

For v3 you can use ->delayInSession(...) see docs

And for v2 you can use $model->addViewWithExpiryDate(...) see docs

@cromartie1984
Copy link

i use the 3.2, thx it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Solved Used for solved questions Type: Question
Projects
None yet
Development

No branches or pull requests

3 participants