xfer fails on unlimited quota (-1)

[brong]

From: Wolfgang Breyha
Bugzilla-Id: 3559
Version: 2.4.11
Owner: Bron Gondwana

[brong]

Attachment-Id: 1424
From: Wolfgang Breyha
Type: text/plain
File: cyrus-imapd-2.4.11-setquotafix.patch

fix for xfer_setquotaroot and cmd_setquota

[brong]

From: Bron Gondwana

I swear there was another bug about this already... but I'll investigate and get a fix ready for 2.4.12

[brong]

From: Bron Gondwana

(In reply to comment #1)
> I swear there was another bug about this already... but I'll investigate and
> get a fix ready for 2.4.12

In fact - your patch is great - accepted it as-is. I know it's going to be incompatible with 2.5 in lots of ways, so I don't know if we'll be taking it into mainline, but it will be in 2.4.12. Thanks.

[brong]

From: Jeroen van Meeuwen (Kolab Systems)

(In reply to comment #2)
> (In reply to comment #1)
> > I swear there was another bug about this already... but I'll investigate and
> > get a fix ready for 2.4.12
>
> In fact - your patch is great - accepted it as-is. I know it's going to be
> incompatible with 2.5 in lots of ways, so I don't know if we'll be taking it
> into mainline, but it will be in 2.4.12. Thanks.

Note that with this patch we would accept:

. SETQUOTA user/john@example.org (STORAGE -1)

whereas previously we only accepted:

. SETQUOTA user/john@example.org ()

The former currently results in a bad argument list error in 2.4.11.

[brong]

From: Bron Gondwana

(In reply to comment #3)
> Note that with this patch we would accept:
>
> . SETQUOTA user/john@example.org (STORAGE -1)
>
> whereas previously we only accepted:
>
> . SETQUOTA user/john@example.org ()
>
> The former currently results in a bad argument list error in 2.4.11.

Yeah, I'm not too disturbed about that - it's syntax that wouldn't have been accepted otherwise, and it doesn't add any capabilities that didn't exist before. AKA, I don't care that it leaks - and it fixes interoperability with old versions.