-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JMAP Email/import setting hasAttachment when it shouldn't? #2389
Comments
I wonder if this is actually an annotator bug... looks like you're testing against a local instance. |
Yeah, this is on my local vm. Let me know if you want configs or any info |
Yes, looks like an annotator issue for top-level messages:
But for embedded emails it could be an issue with the JMAP bodypart parser. |
Wait a second, this could be a bug in the JMAP Email/import code. I'm just rewriting the code use |
So, this should be fixed in 7677ede (there's also a test at cyrusimap/cassandane@bcfb787). But there's lots of ceremony in Email/import et al in the JMAP code to handle But currently, it looks as if we set the hasAttachment flag during email creation/import, which triggers the annotator, which again determines the hasAttachment flag. We might choose one of the following options:
|
Wearing release manager hat, I don't like this as an option. People struggle enough with getting fundamentals like smtp and sasl working, without mandating they scaffold up and maintain an annotator script too.
This sounds good to me. Default it to on, and places like FastMail that already have that functionality externally can turn it off. |
Email/import of file without attachments results in an Email object with hasAttachment true (but no attachments):
The text was updated successfully, but these errors were encountered: