Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync_client and other command line tools shouldn't use "fatal" for incorrect command line options #2871

Open
brong opened this issue Sep 12, 2019 · 1 comment
Assignees

Comments

@brong
Copy link
Member

brong commented Sep 12, 2019

#3 0x0000000000407fb3 in main (argc=6, argv=0x7ffc41da3808) at imap/sync_client.c:1009
1009 fatal("No replication mode specified", EX_USAGE);

This causes core dumps in the Fastmail environment, which is annoying!

@elliefm elliefm self-assigned this Sep 13, 2019
@elliefm
Copy link
Contributor

elliefm commented Sep 16, 2019

Fixed for sync_client by 70600b5

I had a look for other command places doing this (ack 'fatal.*EX_USAGE' and just ack EX_USAGE) and the rest all seem like legit fatal calls from service processes, or at least from things that have not been discovered until after work has started (e.g. cyr_virusscan validating search strings)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants