Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls_th-lock.c: compile without ssl.h #4770

Merged
merged 1 commit into from Dec 17, 2023
Merged

tls_th-lock.c: compile without ssl.h #4770

merged 1 commit into from Dec 17, 2023

Conversation

dilyanpalauzov
Copy link
Contributor

./configure --without-openssl && make produces

External dependencies:
   openssl:            no
…
  CC       imap/libcyrus_imap_la-tls_th-lock.lo
imap/tls_th-lock.c:11:10: fatal error: openssl/ssl.h: No such file or directory
   11 | #include <openssl/ssl.h>
      |          ^~~~~~~~~~~~~~~

This change permits compiling Cyrus IMAP after ./configure --without-openssl && make, when ssl.h is missing.

elliefm
elliefm approved these changes Dec 17, 2023
View reviewed changes
Copy link
Contributor

@elliefm elliefm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@elliefm elliefm merged commit fe6ac73 into cyrusimap:master Dec 17, 2023
1 check passed
@dilyanpalauzov dilyanpalauzov deleted the tls_th_lock_no_openssl branch December 18, 2023 18:20
@dilyanpalauzov
Copy link
Contributor Author

This shall be backported.

@elliefm elliefm added backport-to-3.6 for PRs that are to be backported to 3.6 backport-to-3.4 for PRs that are to be backported to 3.4 backport-to-3.2 for PRs that are to be backported to 3.2 backport-to-3.8 for PRs that are to be backported to 3.8 and removed backport-to-3.6 for PRs that are to be backported to 3.6 labels Jan 21, 2024
@elliefm elliefm removed the backport-to-3.8 for PRs that are to be backported to 3.8 label Feb 26, 2024
@elliefm elliefm removed backport-to-3.4 for PRs that are to be backported to 3.4 backport-to-3.2 for PRs that are to be backported to 3.2 labels Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliefm elliefm elliefm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dilyanpalauzov @elliefm