Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http_carddav.c: Don't allow the Default addressbook to be deleted #4828

Merged
merged 1 commit into from Mar 4, 2024
Merged

http_carddav.c: Don't allow the Default addressbook to be deleted #4828

merged 1 commit into from Mar 4, 2024

Conversation

ksmurchison
Copy link
Contributor

No description provided.

@ksmurchison ksmurchison added backport-to-3.6 for PRs that are to be backported to 3.6 backport-to-3.8 for PRs that are to be backported to 3.8 backport-to-3.10 for PRs that are to be backported to 3.10 labels Mar 1, 2024
@ksmurchison ksmurchison force-pushed the carddav_protect_default_abook branch from fdf5175 to 832c4c6 Compare March 2, 2024 11:46
elliefm
elliefm approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@elliefm elliefm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One nit, but doesn't need re-review after it's fixed

cassandane/Cassandane/Cyrus/Carddav.pm Outdated Show resolved Hide resolved
rsto
rsto approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@rsto rsto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in addition to what @elliefm said

@ksmurchison ksmurchison force-pushed the carddav_protect_default_abook branch from 832c4c6 to e578a14 Compare March 4, 2024 12:25
@ksmurchison ksmurchison merged commit 2955da8 into master Mar 4, 2024
2 checks passed
@ksmurchison ksmurchison deleted the carddav_protect_default_abook branch March 4, 2024 12:52
@elliefm elliefm removed backport-to-3.6 for PRs that are to be backported to 3.6 backport-to-3.8 for PRs that are to be backported to 3.8 backport-to-3.10 for PRs that are to be backported to 3.10 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsto rsto rsto approved these changes

@elliefm elliefm elliefm approved these changes

@brong brong Awaiting requested review from brong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ksmurchison @rsto @elliefm