Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new stars #1

Closed
JMejuto opened this issue Jun 28, 2023 · 5 comments
Closed

Adding new stars #1

JMejuto opened this issue Jun 28, 2023 · 5 comments

Comments

@JMejuto
Copy link

JMejuto commented Jun 28, 2023

Hi,

it is more a question than an issue of your helpful piece of code. Is there any possibility to add new stars like Thuban or others that the user can define? It would be great for research and teaching purposes.

Thank you in advance for your time

@cyschneck
Copy link
Owner

Ah, that is a good feature idea, I'll work on adding it now 👍

@JMejuto
Copy link
Author

JMejuto commented Jun 28, 2023

Thank you so much!!

@cyschneck
Copy link
Owner

These new changes are up with the v1.5.0 release. Should be available via a pip upgrade. I will still be working on some testing for some edge cases, but it appears to be working as expected now

You can add as many new stars are you'd like by creating a newStar and added into the finalPositionOfStars() and plotStereographicProjection() with the new userDefinedStars argument

Please note that for clarity sake I changed the argument userListOfStars to builtInStars so that might impact some backwards compatibility. All the details are included with examples in the most current README.md

But otherwise I will continue to add tests and debug the existing work, so if you find any new ideas or issues or areas that could be more clear, don't hesitate to ask

@JMejuto
Copy link
Author

JMejuto commented Jun 30, 2023

Thank you for your time, that was fast! It works like a charm, be sure that it will be useful used, and appreciated in my daily work.

@cyschneck
Copy link
Owner

Wonderful to hear, if you need any future features, feel free to ask 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants