Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntelliJ "New UI" compatibility #142

Closed
gsaslis opened this issue Dec 2, 2022 · 9 comments · Fixed by #166
Closed

IntelliJ "New UI" compatibility #142

gsaslis opened this issue Dec 2, 2022 · 9 comments · Fixed by #166
Assignees
Labels
Weeks Tasks that take longer than DAYS
Milestone

Comments

@gsaslis
Copy link
Collaborator

gsaslis commented Dec 2, 2022

Jetbrains has a "New UI" : https://blog.jetbrains.com/idea/2022/05/take-part-in-the-new-ui-preview-for-your-jetbrains-ide/

TODO:

  • document how to show the radicle toolbar icons
  • document how to view the radicle menus
  • ensure shortcuts still work
  • ensure actions still work (cmd/ctrl + shift + a)
  • ensure clone / publish / push still work
  • fix visual styling (e.g. icons, borders, etc. ) in case something looks out of place
@gsaslis gsaslis added this to the 0.3.0 milestone Dec 2, 2022
@gsaslis gsaslis added Days Tasks that take longer than HOURS but less than a WEEK Weeks Tasks that take longer than DAYS and removed Days Tasks that take longer than HOURS but less than a WEEK labels Dec 2, 2022
@Stelios123 Stelios123 self-assigned this Jan 10, 2023
@Stelios123
Copy link
Contributor

Stelios123 commented Jan 10, 2023

Below are some pictures of how the icons looks in the old and new UI (First & Second bullet)

Image

Image

Image

I think we need other icons for the new ui

@Stelios123
Copy link
Contributor

Stelios123 commented Jan 10, 2023

Third / Fourth bullet

Work as expected

Fifth bullet

All actions work as expected

Sixth bullet

The border of Textarea was a little bit messy but I fix it.

Maybe we need to change all the icons to match the dark theme

@gsaslis
Copy link
Collaborator Author

gsaslis commented Jan 12, 2023

@Stelios123 ok, if you need something specific for the icons, please reach out to Michalis on Discord.

@gsaslis
Copy link
Collaborator Author

gsaslis commented Jan 12, 2023

otherwise, it sounds like this issue is basically done ?

@Stelios123
Copy link
Contributor

Correct

@JChrist
Copy link
Member

JChrist commented Jan 12, 2023

I think we will also need a way to switch appearance/icons based on underlying platform appearance, i.e. if new ui is enabled or not.

@Stelios123
Copy link
Contributor

Stelios123 commented Jan 12, 2023

We can switch icons based on the theme (Light / Dark). I don't know if we can switch icons based on the new/old UI. Also i don't know if we need to do that

@Stelios123
Copy link
Contributor

Stelios123 commented Jan 12, 2023

I talk with micmei and we decided to change the appearance of rad icons only in the new UI. Any objections ?

Image
Image

@gsaslis
Copy link
Collaborator Author

gsaslis commented Jan 12, 2023

@Stelios123 sounds good to me

(but I admit I didn't quite understand @JChrist 's comment, so we better get a 👍🏼 from him too...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Weeks Tasks that take longer than DAYS
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants