Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failures and compiler warnings with the clang compiler #1325

Closed
robertwb opened this issue Apr 22, 2012 · 2 comments
Closed

Test failures and compiler warnings with the clang compiler #1325

robertwb opened this issue Apr 22, 2012 · 2 comments

Comments

@robertwb
Copy link
Contributor

A while ago I reported a few issues on the cython-users mailing list:
https://groups.google.com/d/topic/cython-users/tWpJJS40KJI/discussion

I believe all the issues that were discussed are still present and are all related to the clang compiler:

  1. OpenMP tests should be skipped with the clang compiler
  2. Replace self-assignment hack to avoid unused parameter warnings with CYTHON_UNUSED
  3. __Pyx_Method_ClassMethod sometimes included unnecessarily
  4. Make runtests.py display the commands it is executing

Please see the comments by Stefan Behnel in the mailing list thread.

Attached find complete Cython build and test logs for 5fcc3e2 for Mac OS X Lion with Xcode 4.3.
The test failures are still there, the compiler warnings changed a bit in the meantime, especially I think there are quite a few new unused function warnings.

Given that clang is getting more and more common (default compiler on the Mac) and finds issues gcc doesn't, would it be possible to include clang on the Cython build / test server (this was mentioned as a possibility by Stefan in the mailing list thread)?
If not I would be of course happy to re-run any builds / tests to diagnose these issues.

Thank you for developing Cython!

At 2012-04-22T22:03:20Z deil added attachment cython-build.log

At 2012-04-22T22:03:52Z deil added attachment cython-tests.log

Migrated from http://trac.cython.org/ticket/770

@robertwb
Copy link
Contributor Author

scoder changed cc to deil
milestone from wishlist to 0.17
owner from somebody to scoder
commented

  1. and 2. should be fixed already in the latest master.

@scoder
Copy link
Contributor

scoder commented Feb 9, 2019

This is essentially done. Not worth keeping it open.

@scoder scoder closed this as completed Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants