New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Parallelization tutorial #5184
Conversation
I think it's breaking clang
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge +1 for this tutorial! I found just some small typos for now. One note regarding the PR, pure python is missing but this can be done even in next PR + the tutorial uses also new keyword which is missing in pure python mode.
Co-authored-by: Matus Valo <matusvalo@users.noreply.github.com>
Mainly laziness...
We could use a |
No worries. We can go even with this version and I am willing to migrate it to pure python mode afterwards. |
I've added the pure Python examples. Unlike the rest of the documentation I've put the Cython examples first. Mainly because I prefer it that way. Obviously with it being open source other people can come in later and swap that around but I thought I'd do it my way initially. |
Might make it work on OSX
Co-authored-by: Matus Valo <matusvalo@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another batch of possible improvements
Co-authored-by: Matus Valo <matusvalo@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm going to merge this. It's docs so it's not going to break anything... |
I've written a parallelization tutorial. It doesn't cover that much new ground from the main parallelization documents, but hopefully it present a separate example of each use case, and is a little less of "here are the parameters, good luck" than the main parallelization reference
Kind of closes #5125