Support match_args in cdef dataclasses #5381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of cython#4303 Currently a draft PR because it's based on cython#4989
da-woods
commented
Apr 14, 2023
| for field_name, field in fields.items(): | ||
| # TODO hasattr and global_kw_only can be removed once full kw_only support is added | ||
| field_is_kw_only = global_kw_only or ( | ||
| hasattr(field, 'kw_only') and field.kw_only.value |
There was a problem hiding this comment.
This hasattr is only in to anticipate adding a kw_only attribute to field, so that it behaves correctly when that happens. Obviously when that does happen we won't need it.
It's a bit clunky, but it's just future-proofing, and can be removed later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4303
This was originally supposed to go on top of #4989, but that's a pretty complicated PR while this is very simple and can be isolated so it may as well come first