New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
codespell: add config, workflow (so no new typos sneak in) and get some typos fixed #5608
Conversation
=== Do not change lines below === { "chain": [], "cmd": "codespell -w", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^
I think this is probably worth doing. Will give it a few days to see if there's any objections, but if not I'll merge it. |
I also don't think "delimeters" is really in an API that anyone uses. I know Numpy/Scipy/Pandas/Scikit (and probably others) learn do use tempita in places, but not via those interfaces. So I think I'd be comfortable with that change too. |
ok, should I provide compatibility/deprecation layer to possibly ease transition for a possible happen to be user? edit: probably would do it as a separate PR for ease of review/etc |
Thanks. Think this should be useful. Still not quite sure about the delimiter/delimeter issue
I think if we do change it we should just change it and not do a compatibility layer.
Yeah that's what I decided - separate out the trickier bit |
Config does exclude quite a bit of ideosyncratic constructs and even a typo (
delimeters
) which is now part of the API, so I decided to leave it alone for this round.