Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codespell: add config, workflow (so no new typos sneak in) and get some typos fixed #5608

Merged
merged 7 commits into from Aug 14, 2023

Conversation

yarikoptic
Copy link
Contributor

Config does exclude quite a bit of ideosyncratic constructs and even a typo (delimeters) which is now part of the API, so I decided to leave it alone for this round.

@da-woods
Copy link
Contributor

I think this is probably worth doing. Will give it a few days to see if there's any objections, but if not I'll merge it.

@da-woods
Copy link
Contributor

I also don't think "delimeters" is really in an API that anyone uses. I know Numpy/Scipy/Pandas/Scikit (and probably others) learn do use tempita in places, but not via those interfaces. So I think I'd be comfortable with that change too.

@yarikoptic
Copy link
Contributor Author

yarikoptic commented Aug 14, 2023

I also don't think "delimeters" is really in an API that anyone uses. I know Numpy/Scipy/Pandas/Scikit (and probably others) learn do use tempita in places, but not via those interfaces. So I think I'd be comfortable with that change too.

ok, should I provide compatibility/deprecation layer to possibly ease transition for a possible happen to be user?

edit: probably would do it as a separate PR for ease of review/etc

@da-woods da-woods added this to the 3.0.1 milestone Aug 14, 2023
@da-woods da-woods merged commit bea98eb into cython:master Aug 14, 2023
76 checks passed
@da-woods
Copy link
Contributor

Thanks. Think this should be useful.

Still not quite sure about the delimiter/delimeter issue

ok, should I provide compatibility/deprecation layer to possibly ease transition for a possible happen to be user?

I think if we do change it we should just change it and not do a compatibility layer.

edit: probably would do it as a separate PR for ease of review/etc

Yeah that's what I decided - separate out the trickier bit

scoder added a commit that referenced this pull request Aug 24, 2023
… keep a legacy fallback (with deprecation warning) at the main API level.

See discussion in #5608
Closes #5627
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants