Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -Wundef -Wstrict-prototypes #5756

Merged
merged 1 commit into from Oct 9, 2023
Merged

Conversation

prj-
Copy link
Contributor

@prj- prj- commented Oct 8, 2023

src/petsc4py/PETSc.c:22:5: warning: 'CYTHON_LIMITED_API' is not defined, evaluates to 0 [-Wundef]
#if CYTHON_LIMITED_API
    ^
src/petsc4py/PETSc.c:5283:47: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
static unsigned long __Pyx_get_runtime_version();
                                              ^
                                               void
src/petsc4py/PETSc.c:561483:49: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
  static unsigned long __Pyx_get_runtime_version() {
                                                ^
                                                 void
3 warnings generated.

@matusvalo matusvalo added this to the 3.0.x milestone Oct 8, 2023
@prj-
Copy link
Contributor Author

prj- commented Oct 9, 2023

@matusvalo, if you think my changes will effectively address the warnings reported in the PR description (I have no idea myself), could you please get this integrated?

@scoder scoder added the defect label Oct 9, 2023
@scoder
Copy link
Contributor

scoder commented Oct 9, 2023

Looks right. Thanks.

@scoder scoder merged commit f4b10ff into cython:master Oct 9, 2023
76 checks passed
@scoder scoder modified the milestones: 3.0.x, 3.0.4 Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants