Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 703: Rename PY_NOGIL to Py_GIL_DISABLED #5852

Merged
merged 2 commits into from Nov 20, 2023
Merged

PEP 703: Rename PY_NOGIL to Py_GIL_DISABLED #5852

merged 2 commits into from Nov 20, 2023

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Nov 20, 2023

@colesbury
Copy link
Contributor

colesbury commented Nov 20, 2023 •
edited

I would prefer 'defined(Py_GIL_DISABLED) || defined(Py_NOGIL)' until the 3.13 release because the nogil fork is still in use, including in the scikit-learn continuous build.

@hugovk
Copy link
Contributor Author

hugovk commented Nov 20, 2023

Sure, updated!

@scoder scoder added this to the 3.0.x milestone Nov 20, 2023
@scoder scoder merged commit fcd5a49 into cython:master Nov 20, 2023
63 checks passed
@hugovk hugovk deleted the rename-Py_NOGIL branch November 20, 2023 16:02
scoder pushed a commit that referenced this pull request Nov 20, 2023
@hugovk @scoder
PEP 703: Accept new Py_GIL_DISABLED macro in addition to PY_NOGIL (…
f258b67 
…GH-5852)

See python/cpython#111863
See python/cpython#111864
@scoder
Copy link
Contributor

scoder commented Nov 20, 2023

3.0.x commit is f258b67

@da-woods da-woods mentioned this pull request Apr 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Code Generation
Projects
None yet
Milestone
3.0.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hugovk @colesbury @scoder