Implement return type inference for methods of builtin types #5865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da-woods
reviewed
Nov 24, 2023
Comment on lines
+572
to
+573
| if 'T' in return_type_name: | ||
| return_type_name = return_type_name.replace('T', builtin_type.name) |
There was a problem hiding this comment.
I don't think this is used, given you drop everything in front of the [ earlier. It also feels a little fragile to me (although I can't see anywhere above where it should fail)
There was a problem hiding this comment.
Yeah, the "drop the '[' part" is actually meant as a temporary work-around for our lack of generics. It should get removed at some point. I had considered to add a comment and I should have.
…s also never do it for indexing.
…s node type (if it comes out as a Python type).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.