Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move result_code from analysis to generation #626

Closed
robertwb opened this issue Sep 5, 2008 · 7 comments
Closed

Move result_code from analysis to generation #626

robertwb opened this issue Sep 5, 2008 · 7 comments

Comments

@robertwb
Copy link
Contributor

robertwb commented Sep 5, 2008

In Pyrex, rather than the result_code being filled in at analysis time, there's a result() method being called during code generation. Moving filling ; then the result temp can be allocated using CodeWriter and so on.

See Greg Ewing's posts in this thread].

A lot of things are blocked by this:

  • Complex numbers in buffers without a lot of changes/workarounds (http://trac.cython.org/ticket/56)
  • Closures and generators were off to a good start but where also blocked by this.

My personal opinion is that the workarounds will only pile up, while a change like this could potentially be done without too much trouble and would make it possible to start streamlining some code (especially stop worrying about figuring out workarounds for new code).

Migrated from http://trac.cython.org/ticket/67

@robertwb
Copy link
Contributor Author

robertwb commented Sep 5, 2008

@dagss changed summary from

Move generation of result_code string from

to

Move result_code string from analysis to generation
commented

@robertwb
Copy link
Contributor Author

robertwb commented Sep 5, 2008

@dagss changed summary from

Move result_code string from analysis to generation

to

Move result_code from analysis to generation
commented

@robertwb
Copy link
Contributor Author

robertwb commented Sep 5, 2008

@dagss commented

The relevant Pyrex commit is here:

http://hg.cython.org/pyrex/rev/da6e97bb7e6d

@robertwb
Copy link
Contributor Author

robertwb commented Sep 5, 2008

@dagss changed owner from somebody to dagss
status from new to assigned
commented

@robertwb
Copy link
Contributor Author

@dagss changed owner from dagss to robertwb
status from assigned to new
commented

@robertwb
Copy link
Contributor Author

@robertwb changed milestone from wishlist to 0.9.8.2
resolution to fixed
status from new to closed
commented

This has been done in http://hg.cython.org/cython-devel/rev/eedadcc8c22c

@robertwb
Copy link
Contributor Author

robertwb commented Sep 23, 2008

@robertwb commented

Note that temp allocation is still done in the analysis phase, see http://trac.cython.org/ticket/77 for moving it to code generation.

@robertwb robertwb added this to the 0.10 milestone Aug 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant