Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embedsignatures discards existing cpdef docstrings #734

Closed
robertwb opened this issue Jan 3, 2009 · 5 comments
Closed

embedsignatures discards existing cpdef docstrings #734

robertwb opened this issue Jan 3, 2009 · 5 comments

Comments

@robertwb
Copy link
Contributor

robertwb commented Jan 3, 2009

The embedsignatures compiler directive causes method signatures to be prepended to docstrings, but it fails to preserve existing docstrings for cpdef methods. The attached patch fixes the problem.

At 2009-01-06T01:23:21Z jasone added attachment embedsignature.patch

Migrated from http://trac.cython.org/ticket/175

@robertwb
Copy link
Contributor Author

robertwb commented Jan 4, 2009

@dagss commented

One should also have a test case to check that this works for cpdef methods in classes.

@robertwb
Copy link
Contributor Author

scoder changed resolution to fixed
status from new to closed
commented

Applied, thanks!

http://hg.cython.org/cython-devel/rev/4486c09becf3

@robertwb
Copy link
Contributor Author

@robertwb changed resolution from fixed to empty
status from closed to reopened
commented

@robertwb
Copy link
Contributor Author

@robertwb changed owner from somebody to jasone
status from reopened to new
commented

@robertwb
Copy link
Contributor Author

@robertwb changed resolution to fixed
status from new to closed
commented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant