Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store a pointer to neighboring tiles in mapNodes #71

Closed
SimplyLiz opened this issue Feb 21, 2019 · 1 comment
Closed

Store a pointer to neighboring tiles in mapNodes #71

SimplyLiz opened this issue Feb 21, 2019 · 1 comment
Assignees
Labels
core affects the core / engine refactoring

Comments

@SimplyLiz
Copy link
Contributor

Instead of providing a function to get a mapNodes neighbors in the map class, the (3x3) neighbors could be stored as pointers in the mapNode itself to avoid having to call the function every time neighbors need to be accessed.

It's probably not worth the effort performance wise, but it'd be cleaner this way and the responsiblity of tracking it's neighbors would go to the mapNode class.

@SimplyLiz SimplyLiz added enhancement New feature or request refactoring labels Feb 21, 2019
@SimplyLiz SimplyLiz added this to the v0.1.1 tech preview release milestone Feb 21, 2019
@SimplyLiz SimplyLiz added core affects the core / engine and removed enhancement New feature or request labels Feb 24, 2019
@Paragoumba Paragoumba self-assigned this Sep 27, 2019
@SimplyLiz
Copy link
Contributor Author

Discarded. After discussion it turned out to not make much sense to change this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core affects the core / engine refactoring
Projects
None yet
Development

No branches or pull requests

2 participants