Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XcodeServerEndpoints refactoring proposition #79

Closed
pmkowal opened this issue Jul 23, 2015 · 2 comments
Closed

XcodeServerEndpoints refactoring proposition #79

pmkowal opened this issue Jul 23, 2015 · 2 comments

Comments

@pmkowal
Copy link
Contributor

pmkowal commented Jul 23, 2015

Hi guys, recently I was playing a little bit with Xcode Server and I would be glad to help you i.e. increasing test coverage.

After look at the project, I thought it would be good to test e.g. endpointURL method in the XcodeServerEndpoints class. But since it is a private method, I would suggest to move this method to a seperate class and make this method internal. What do you think?

@czechboy0
Copy link
Member

Hi @pmkowal,

thanks! That would be great if you could help out. Yeah it makes sense to make endpointURL internal (just remove private), but I don't think you need to move it to another class.

@pmkowal
Copy link
Contributor Author

pmkowal commented Jul 23, 2015

@czechboy0 ok, so I will do it as you proposed.
I just thought it would be good to share the responsibility of creating requests and providing endpoints between seperate classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants