Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds iOS target #25

Merged
merged 3 commits into from Jun 21, 2015
Merged

Adds iOS target #25

merged 3 commits into from Jun 21, 2015

Conversation

esttorhe
Copy link
Member

Fix #24

I just created a new target with its own test target and "redirected" the same tests to run for the mobile architecture.

A couple of conditional target imports in 3 files and the project now supports iOS framework with tests passing :)

@cojoj cojoj mentioned this pull request Jun 19, 2015
@cojoj
Copy link
Contributor

cojoj commented Jun 20, 2015

@esttorhe I've checked your PR and it looks fine but I suggest you change both target names to follow some pattern eg.

  • XcodeServerSDK - OS X
  • XcodeServerSDK - OS X Tests
  • XcodeServerSDK - iOS
  • XcodeServerSDK - iOS Tests

Also I've noticed that Tests for new iOS target are marked as red in Product directory. You know something about this and where to fix this?

When you fix these things I think this PR will be ready to merge from my POV.

I've also checked - your PR will allow us to use Playground inside project so we can interact with SDK. Everything in that matter is configured as it should be and is described in #26.


Good job! 😉 👌

- Removed Info.plist for iOS and now using same one as OSX
@esttorhe
Copy link
Member Author

Here's the list of fixes:

    1. Renamed targets as suggested on your comment
    1. Removed Info.plist for iOS target as its not needed (using same as the OSX target)
    1. Renamed product names

Regarding your question of the test target in red; basically Xcode is a «String based» IDE, now that both targets share the same product names Xcode will search for the same (in this case OSX one) and that's why you see both iOS and OSX targets in black (because both products are pointing to the same artifact) but the test target had different names and Xcode was looking for the iOS test product in the same folder as the OSX ones failing to find it. ¯_(ツ)_/¯

@czechboy0
Copy link
Member

Awesome, thanks @esttorhe and @cojoj. I have some slight edits for this but I'll merge this first and push those changes to the original repo's swift-2 branch right after.

czechboy0 pushed a commit that referenced this pull request Jun 21, 2015
@czechboy0 czechboy0 merged commit fe68498 into buildasaurs:swift-2 Jun 21, 2015
@czechboy0 czechboy0 mentioned this pull request Jun 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants