Testing and refactoring #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "Key3": "Value3" | ||
| ] | ||
|
|
||
| XCTAssertEqual(HTTP.stringForQuery(query), "?Key3=Value3&Key1=Value1&Key2=Value2") |
There was a problem hiding this comment.
From The Swift Programming Language:
Swift’s
Dictionarytype does not have a defined ordering. To iterate over the keys or values of a dictionary in a specific order, use thesort()method on itskeysorvaluesproperty.
And I just copied it from Playground, so that's why the expectation is strange
There was a problem hiding this comment.
Sure, let's sort them (I added a comment above).
| @@ -3,7 +3,7 @@ | |||
| version = "3.0"> | |||
| <TimelineItems> | |||
| <LoggerValueHistoryTimelineItem | |||
| documentLocation = "#CharacterRangeLen=11&CharacterRangeLoc=338&EndingColumnNumber=18&EndingLineNumber=13&StartingColumnNumber=5&StartingLineNumber=13&Timestamp=456581904.255022" | |||
| documentLocation = "#CharacterRangeLen=0&CharacterRangeLoc=258&EndingColumnNumber=18&EndingLineNumber=23&StartingColumnNumber=5&StartingLineNumber=23&Timestamp=456844329.662716" | |||
There was a problem hiding this comment.
Can you just revert this change?
|
Please just revert the playground timeline xml change and I'll merge this, @cojoj. Thanks for the work you put into it! |
…erverSDK into testing_refactoring
|
@czechboy0 I've rebased and reverted |
|
Thanks, @cojoj! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created another two test classes and also made some refactoring where I found it important.
I've also documented some methods so please check if this style of documenting is suitable - it follows the new Swift 2 standards.