Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oi! 馃嚞馃嚙
I've created test suite for
XcodeServerEndpoints
with purpose of testingcreateRequest()
but it looks like it's mostly tested (or at least covered in other tests), so I've only created test case for malformed URLs passed to this method.We're missing code coverage for those lines:
but it's complicated as I can't invent any failable case for
NSJSONSerialization.dataWithJSONObject()
as earlier we make sure we passNSDictionary
and any valid dictionary will be a valid JSON in that case.Still no update for
guard
statement bug and code put directly afterguard
is never marked in test coverage... 馃槶