New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XcodeServerEndpoints.createRequest tests #84
XcodeServerEndpoints.createRequest tests #84
Conversation
Result of Integration 1Duration: 1 minute and 5 seconds |
@pmkowal can you provide a screenshot of test coverage form |
here you go @cojoj: |
Nah, the test coverage in code... You know, this fancy indicators showing which lines has been tested 😉 |
@cojoj are you concerned with buildasaur result of integration? |
Nope, just want to see coverage and give you ans answer to
|
Cool, I didn't look at it, thx @cojoj |
Ok, I know now how to test |
Great I was just writing about his authorization part but if you know how to solve this good for you! 🍹 Now, the Hope you get me 😉 |
The point is tried to provide failbale JSON, but I couldn't figure it out 😄, because we can use only |
@cojoj ...and with |
Exactly... That's what I've been struggling with too 😕 You can move |
I'd be great if we have read access to |
I was rather thinking of creating another
😁 |
Oh okay... If it's |
Result of Integration 2Duration: 52 seconds |
ok @cojoj |
…uest-tests XcodeServerEndpoints.createRequest tests
Great stuff, thanks @pmkowal! |
👍 |
Hey, I added three tests for
createRequest
method, but I don't have a clue how to 100% cover theXcodeServerEndpoints
class.Please take a look.
Btw. I have one proposition regarding
XcodeServer
class.I would move the code below (from
sendRequestWithMethod
method) tocreateRequest
method, becausecreateRequest
method can figure outHTTP.Method
directly from its parameter. What do you think?