Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If SVG file has fill attribute at path tag, this attribute is not working when we set fill property on [svgStyle]. #76

Open
umutdeveloper opened this issue Jun 24, 2019 · 4 comments

Comments

@umutdeveloper
Copy link

If SVG file has fill attribute at path tag, this attribute is not working when we set fill property on [svgStyle] because this attribute is adding fill attribute only to svg tag. But svg file has another fill propert on path tag in svg tag.

image

Originally posted by @umutcakirbm in #40 (comment)

@jettzhang95
Copy link

If SVG file has fill attribute at path tag, this attribute is not working when we set fill property on [svgStyle] because this attribute is adding fill attribute only to svg tag. But svg file has another fill propert on path tag in svg tag.

Originally posted by @umutcakirbm in #40 (comment)

I also meet this problem, have you solved it?

@CedricBojoly
Copy link

Its the same problem with the width and height.
If you have a width and height on the svg tag and add a width and height with svgStyle the icon size will not change.
Probably some svgStyles should directly be applied to the svg tag

@czeckd
Copy link
Owner

czeckd commented Jul 8, 2020

I'm not understanding what change is being asked for here. Why not just fix the SVGs you are using?

@filipedtristao
Copy link

filipedtristao commented Jul 8, 2020

I'm not understanding what change is being asked for here. Why not just fix the SVGs you are using?

Yeah, i think this is a better idea. Apply properties from the svg element to the path could be problematic, especially because you can have a svg with multiple paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants