Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZCO-225] Doesn't work with non-MD notes #2

Closed
saif-ellafi opened this issue Sep 24, 2023 · 4 comments
Closed

[ZCO-225] Doesn't work with non-MD notes #2

saif-ellafi opened this issue Sep 24, 2023 · 4 comments
Labels
bug Something isn't working linear Created by Linear-GitHub Sync

Comments

@saif-ellafi
Copy link

saif-ellafi commented Sep 24, 2023

Any none markdown note will not work :(

  • Canvas notes will re-open duplicates.
  • Image notes (PNG, JPG, etc)
  • PDF notes
  • Same for Excalidraw Drawing notes (plugin)

Would it be possible to not de-dup on those kind of notes?

Thank you for creating this

ZCO-225

ZCO-345

@saif-ellafi saif-ellafi changed the title Doesn't work with Canvas or Excalidraw (plugin) Doesn't work with non-MD notes Sep 24, 2023
@czottmann
Copy link
Owner

czottmann commented Sep 25, 2023

Hi @saif-ellafi, I'll look into this but it might be impossible — every time a Markdown file is opened (unless it's pinned, see #1), a notification is sent out to plugins by Obsidian, and this is what Mononote works with. Mononote does not check for file type at all so my suspicion is that there is no such notification for non-MD files.

I'll look into this. Might take a while, though!

@czottmann czottmann added the bug Something isn't working label Sep 25, 2023
@czottmann czottmann added the linear Created by Linear-GitHub Sync label Oct 13, 2023
@czottmann czottmann changed the title Doesn't work with non-MD notes [ZCO-225] Doesn't work with non-MD notes Oct 13, 2023
@czottmann
Copy link
Owner

I'm currently working on this.

@czottmann
Copy link
Owner

@saif-ellafi Quick update: I've implemented the requested feature. I had to jumpt through several hoops to make it work because Obsidian doesn't report opening non-MD files to the plugins. 😅 I think I found a good solution for that, though.

The new feature will be rolled out in v1.1.0, due soon!

@czottmann czottmann added this to the Mononote v1.1.0 milestone Jan 8, 2024
@czottmann czottmann changed the title [ZCO-225] Doesn't work with non-MD notes [ZCO-345] [ZCO-225] Doesn't work with non-MD notes Jan 8, 2024
@czottmann czottmann modified the milestones: Mononote v1.1.0, v.15 Jan 8, 2024
@saif-ellafi
Copy link
Author

brilliant, thanks!

@czottmann czottmann changed the title [ZCO-345] [ZCO-225] Doesn't work with non-MD notes [ZCO-225] Doesn't work with non-MD notes Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working linear Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

2 participants