Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Deprecate cmake for meson #29

Open
HaoZeke opened this issue Jun 26, 2023 · 4 comments
Open

ENH: Deprecate cmake for meson #29

HaoZeke opened this issue Jun 26, 2023 · 4 comments
Assignees

Comments

@HaoZeke
Copy link
Member

HaoZeke commented Jun 26, 2023

I like meson. Also beyond that, as shown in pypotlib meson subprojects make wrapper generation easier by:

  • Separation of concerns (bindings in a separate repo)
  • Less janky dependency handling (compared to git submodules)
  • Generally being more readable / playing with environments better

The last one is subjective, but regardless, I think moving away from cmake would be a good step in modularity. Some considerations will probably come up in the migration related to the way meson handles sub-directories. @RuhiRG this could be a good starting point or a parallel task while you work on the bindings with existing installations :)

@RuhiRG
Copy link
Member

RuhiRG commented Jun 27, 2023

Since I'm still getting used to build systems could we go over this together? Does the meson.build file used to generate the library I added during my pre-GSoC contribution not suffice?

@HaoZeke
Copy link
Member Author

HaoZeke commented Jun 27, 2023

Since I'm still getting used to build systems could we go over this together?

Sure, will catch up on this in our update meeting.

@HaoZeke HaoZeke added the gsoc23 For GSoC23 and related outputs label Jun 27, 2023
@HaoZeke
Copy link
Member Author

HaoZeke commented Jun 27, 2023

Does the meson.build file used to generate the library I added during my pre-GSoC contribution not suffice?

Deprecation is another thing to think about, but essentially we need to add one at the repo root to ensure that it can be used as a valid subproject in the bindings project.

@HaoZeke HaoZeke added todo 🗒️ and removed gsoc23 For GSoC23 and related outputs labels Jun 27, 2023
@HaoZeke HaoZeke self-assigned this Jun 27, 2023
@HaoZeke
Copy link
Member Author

HaoZeke commented Jun 27, 2023

After discussion, it seems that the library builds fine, lua linkage is an issue, but that's not really part of GSoC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants