Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproduce the results on wadi #9

Closed
ccskyyy opened this issue Oct 13, 2021 · 1 comment
Closed

Reproduce the results on wadi #9

ccskyyy opened this issue Oct 13, 2021 · 1 comment

Comments

@ccskyyy
Copy link

ccskyyy commented Oct 13, 2021

Your work is amazing and impressive. When I was trying to reproduce your results on the wadi dataset, there were some problems that I was not clear about.

  1. I used WADI_14days_new.csv as training data, WADI_attackdataLABLE.csv as a test one. Did you also train on those files?
  2. I saw there are four empty columns in the wadi dataset('2_P_001_STATUS', '2_P_002_STATUS', '2_LS_001_AL','2_LS_002_AL'), how did you process these columns? (Did you just drop these four empty columns?)
  3. there are some nan values in the dataset, how did you deal with them in the paper? (I replaced these values with the mean of the columns'.)

And I got these results on wadi data:
F1 score: 0.3994959042218021
precision: 0.5382003395585738
recall: 0.31795386158475425

So I was wondering how did you process the dataset? Any suggestions would be appreciated! Thank you so much! :)

@d-ailin
Copy link
Owner

d-ailin commented Oct 17, 2021

  1. No, we only train on the former data.
  2. We would fill them as zeros.
  3. Yes, we also replace them with the mean of the columns.

We use min-max normalization and you could also check with the detail(e.g. downsampling) in the paper. Thanks.

Notes: please do the min-max normalization first and then downsample.

@ccskyyy ccskyyy closed this as completed Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants