Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify should send card type on invalids/unkowns #47

Closed
hey24sheep opened this issue Oct 21, 2021 · 1 comment
Closed

Identify should send card type on invalids/unkowns #47

hey24sheep opened this issue Oct 21, 2021 · 1 comment

Comments

@hey24sheep
Copy link
Contributor

In code Identify, instead of sending empty array back, it should return card type of "Invalid" or "Unknown" depending on if the card is not found or is shady/bad.

@aloisdg
Copy link
Member

aloisdg commented Oct 21, 2021

It returns an empty array as none were found. Like when you filter with Where and nothing matches you get an empty array. This is not a close issue though. Come talk about it on #3. I will close this one for now.

@aloisdg aloisdg closed this as completed Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants