Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement to optional spec-compliant #116

Closed
d-exclaimation opened this issue Dec 22, 2022 · 4 comments · Fixed by #117
Closed

Improvement to optional spec-compliant #116

d-exclaimation opened this issue Dec 22, 2022 · 4 comments · Fixed by #117
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@d-exclaimation
Copy link
Owner

d-exclaimation commented Dec 22, 2022

Is your feature request related to a problem? Please describe.
It would be great if Pioneer can pass some if not most of the optional spec requirement for GraphQL over HTTP.

Describe the solution you'd like
The changes shouldn't break any existing behaviour of Pioneer and shouldn't require anything done from the user side.

Describe alternatives you've considered
We are slightly at the same compliant as Apollo Server which is technically is enough, but if the optional requirements aren't causing any issues, it should be fine to implement it

Additional context

  • As of Nov 16
    Pioneer is currently passing 36 mandatory requirements, 1 optional requirements given in graphql-http spec
  • Update as of Dec 25
    There are 79 audits in total, Pioneer achieved ✅ 45 pass and ⚠️ 34 warnings (optional)
@d-exclaimation d-exclaimation added the enhancement New feature or request label Dec 22, 2022
@d-exclaimation d-exclaimation added this to the Version 1 milestone Dec 22, 2022
@d-exclaimation d-exclaimation self-assigned this Dec 22, 2022
@d-exclaimation
Copy link
Owner Author

I would try to best to match the optional requirements when possible or make any sense. I will also take note on how other implementation handle these requirements particularly apollo-server

@d-exclaimation
Copy link
Owner Author

d-exclaimation commented Dec 25, 2022

Progress and more details on this will be here shown here.

Once I have Pioneer is a spot where it seemed pretty good and make sense, I would also try adding pioneer into the graphql-http list of spec-compliant implementations

@d-exclaimation
Copy link
Owner Author

d-exclaimation commented Dec 25, 2022

Update (Late Dec 25th)

GraphQL over HTTP audit report

  • 79 audits in total
  • 76 pass
  • ⚠️ 3 warnings (optional)

I feel as this is a pretty good state for now without making any massive changes

@d-exclaimation
Copy link
Owner Author

d-exclaimation commented Dec 25, 2022

Related pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant