Add RString#new_utf8 and string::new_utf8 #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Looks like this PR needs a new version of |
|
FWIW, it'd be nice to have this merged. We're using ruru in a Rails stack to build data that's used in PDF; part of what's included in that is the trademark symbol. Without this fix, we get ASCII encoding errors; with the fix we're good. |
|
Yes, let's do it. I just wanted to merge few more patches to ruby-sys 0.3 related to static libs before starting using it in ruru. But the things take a bit longer than I expected. So I'll simply update ruby-sys dependency and merge this commit |
|
Awesome!
… On Dec 15, 2017, at 13:19, Dmitry Gritsay ***@***.***> wrote:
Yes, let's do it. I just wanted to merge few more patches to ruby-sys 0.3 related to static libs before starting using it in ruru. But the things take a bit longer than I expected. So I'll simply update ruby-sys dependency and merge this commit
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@mikeycgto, could you please rebase the branch? |
These functions will return a new Ruby string with UTF8 encoding. This is for the issue described in d-unsed#67
mjc-gh
force-pushed
the
string-new-utf8
branch
from
6a98907
to
e3639c9
Compare
|
Sorry for the delay, should be rebased! Thanks for getting this merged in @d-unseductable 👍 |
|
Thank you, @mikeycgto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions will return a new Ruby string with UTF8 encoding. This is for the issue described in #67