New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decoding message integrity should check message integrity #2

Open

nickdesaulniers opened this issue Jan 1, 2016 · 0 comments

nickdesaulniers commented Jan 1, 2016

vs-stun/lib/attribute/MessageIntegrity.js

Line 32 in 155f8e5

exports.decode = function decode ( packet, value ) {

Needs to do more work as specified by https://tools.ietf.org/html/rfc5389#section-15.4. I need this check to comply with https://tools.ietf.org/html/draft-ietf-ice-rfc5245bis-00#section-6.2 for https://github.com/nickdesaulniers/node-rtc-peer-connection.

Excellent lib by the way, I'm using it in the above linked project.

nickdesaulniers mentioned this issue

respond to stun binding requests nickdesaulniers/node-rtc-peer-connection#48

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment