Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe the WASM files should be compiled from devilutionX project which is based on SDL2 #48

Closed
ZaDarkSide opened this issue Aug 4, 2019 · 5 comments

Comments

@ZaDarkSide
Copy link

In order to sort out the dependencies issues better, maybe it will be best to compile the WASM files from the https://github.com/diasurgical/devilutionX/ project which has support for SDL2 and Emscripten supports SDL2.

@d07RiV
Copy link
Owner

d07RiV commented Aug 4, 2019

It would need a rewrite either way, since JS needs a centralized event loop, and that project still has lots of modal dialogs and other states like the original game. And I prefer having more control over how things are connected to JS.

@ZaDarkSide
Copy link
Author

The guys from devilutionX project are fine with supporting Emscripten in the future as a target platform, it's a lot of work but it can be done.

diasurgical/devilutionX#218

@d07RiV
Copy link
Owner

d07RiV commented Aug 4, 2019

Well I already made mine so it would be too much of a hassle.

Besides, from what I understand, SDL support is mainly aimed at producing a complete HTML page with all the glue code, so adding any additional JS-side functionality (such as touch support) would be difficult.

@ghost
Copy link

ghost commented Aug 4, 2019

I think devilutionx is already working on touch support.

@d07RiV
Copy link
Owner

d07RiV commented Aug 5, 2019

I'm going to close this, as devilutionX seems far away from being able to compile to emscripten, and I like the way I have set it up right now. The main drawback is broken network code, which I may or may not fix in the future.

@d07RiV d07RiV closed this as completed Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants