Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyrighted image #107

Closed
reinerh opened this issue Oct 21, 2020 · 5 comments · Fixed by #108
Closed

Copyrighted image #107

reinerh opened this issue Oct 21, 2020 · 5 comments · Fixed by #108
Labels
bug Something isn't working

Comments

@reinerh
Copy link

reinerh commented Oct 21, 2020

Hi,

I recently packaged lookatme for Debian, as I think it is a cool presentation tool. :-)
I wanted to update the package now to the current release, but noticed that you have included the file examples/napoleon_dynamite.jpg, which is not freely licensed.
Could you please replace it with some picture under a free license? This would make packaging easier, as I could re-use your released tarballs, instead of repacking them (and removing the image).

@reinerh reinerh added the bug Something isn't working label Oct 21, 2020
@d0c-s4vage
Copy link
Owner

Gah, definitely! Thank you for bringing this up!

@d0c-s4vage
Copy link
Owner

In ~a minute v2.2.0 will land on pypi. Thanks again for bringing this up, and an especially large thank you for packaging it for debian!!

@d0c-s4vage
Copy link
Owner

Is there anything I can do on my end to make packaging or package maintenance easier?

@reinerh
Copy link
Author

reinerh commented Oct 22, 2020

Thank you for fixing it so quickly!

I'm currently using the source tarball from Github for the package. This contains {{VERSION}} placeholders in a few files.
I just checked the tarball from pypi and noticed that it has been properly replaced there.
But on the other hand the pypi tarball is missing some files compared to the Github tarball, like docs/ and examples/. Because of that I'll keep using the Github tarball to provide documentation and examples in the package. But I'm also carrying a patch that replaces {{VERSION}} with the upstream version.
It would be a bit easier if either the placeholder is also replaced in the Github tarball, or if the pypi tarball had the same contents.
But it's also not a big deal, updating the version in the patch is done in a few seconds. :-)

@SeniorMars
Copy link

SeniorMars commented Mar 29, 2021

Hey I just wanted to note that I packaged lookatme for the AUR. I also packaged the extensions that I saw in this README. It was my first time, but I believe they all work. Anyway, I'm looking forward to seeing how this project progresses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants